Skip to content

Get licence header test working again. #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2019
Merged

Get licence header test working again. #3272

merged 3 commits into from
Feb 25, 2019

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Feb 21, 2019 •
edited
Loading

WIP: DO NOT MERGE (yet) !

We seem to have lost this functionality with #3036
Since some time before that point, the run in the 'main' test sequence was giving a "SKIP: Iris installation did not look like a git repo." message (here, for instance)

I think this is because you need to be in the right directory when running the test.

@pp-mo pp-mo changed the title Set main testing cwd for licence header test to work properly. Get licence header test working again. Feb 21, 2019
@pp-mo pp-mo force-pushed the reenable_coding_tests branch 5 times, most recently from abe4964 to 64dabf5 Compare February 21, 2019 15:22
@pp-mo pp-mo mentioned this pull request Feb 21, 2019
Merged
@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@pp-mo pp-mo force-pushed the reenable_coding_tests branch from b28224e to 6359f53 Compare February 21, 2019 15:57
stickler-ci
stickler-ci reviewed Feb 22, 2019
View reviewed changes
@pp-mo pp-mo force-pushed the reenable_coding_tests branch from 8e0ba3b to e754797 Compare February 22, 2019 16:53
@pp-mo pp-mo force-pushed the reenable_coding_tests branch from 144cb10 to bf9ad75 Compare February 23, 2019 12:55
@pp-mo
Copy link
Member Author

pp-mo commented Feb 23, 2019 •
edited
Loading

Yay, fixed at last !!! 😀

@lbdreyer this was triggered by your comment on #3259

I think it's probably simplest to agree+merge this one first,
then rebase the others (the ones that are going to master, anyway)

Can you check it out ?

@lbdreyer
Copy link
Member

Yep, this looks good! Thanks @pp-mo :)

@lbdreyer lbdreyer merged commit 45a18ab into SciTools:master Feb 25, 2019
@pelson
Copy link
Member

pelson commented Feb 27, 2019

FYI the header rules were significantly relaxed a few weeks ago in https://github.com/SciTools/scitools.org.uk/blob/master/documents/scitools_licensing.md.

Essentially the year is entirely superfluous in the header and can be removed entirely. I've avoided doing it wholesale to any of the projects as I don't want to be touching every single file for no reason. The cartopy test has been updated though to support the new guidelines: https://github.com/SciTools/cartopy/pull/1267/files#diff-6545369fccb2d4d7897214fa6787e86d

No action needed, just wanted to share the knowledge. 👍 on the change here.

@pp-mo
Copy link
Member Author

pp-mo commented Feb 28, 2019 •
edited
Loading

@pelson No action needed, just wanted to share the knowledge

Thanks, perhaps all devs need to push this..
Instead of checking/updating a header year, whenever you touch a sourcefile, you can update the header to new standards, removing the year altogether.
We can all push that agenda as reviewers too, if we can only remember to. 🐘

@lbdreyer lbdreyer mentioned this pull request Feb 28, 2019
Merged
@pp-mo pp-mo mentioned this pull request Feb 28, 2019
Closed
2 tasks
lbdreyer pushed a commit to lbdreyer/iris that referenced this pull request May 30, 2019
@pp-mo @lbdreyer
Get licence header test working again. (SciTools#3272). Cherrypicked and
6af857b 
modified. SKIP this commit during the mergeback.

* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
lbdreyer pushed a commit to lbdreyer/iris that referenced this pull request May 30, 2019
@pp-mo @lbdreyer
Get licence header test working again. (SciTools#3272). Cherrypicked and
81ce9aa 
modified. SKIP this commit during the mergeback.

* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
lbdreyer pushed a commit that referenced this pull request May 30, 2019
@pp-mo @lbdreyer
Get licence header test working again. Cherrypicked and
6a2052f 
modified from (#3272). SKIP this commit during the mergeback.

* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
lbdreyer pushed a commit to lbdreyer/iris that referenced this pull request May 30, 2019
@pp-mo @lbdreyer
Get licence header test working again. Cherrypicked from (SciTools#3272…
a8ee456 
…) and

modified. SKIP this commit during the mergeback.

* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
znicholls pushed a commit to znicholls/iris that referenced this pull request Jun 15, 2019
@pp-mo @znicholls
Get licence header test working again. (SciTools#3272)
52c2326 
* Fix testing cwd for licence header test to work properly.

* Remove redundant test runner --coding-tests key.

* Update all the missed header years.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pp-mo @stickler-ci @lbdreyer @pelson