Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and unify regridding schemes #198

Merged
merged 62 commits into from
May 12, 2023
Merged

Refactor and unify regridding schemes #198

merged 62 commits into from
May 12, 2023

Conversation

stephenworsley
Copy link
Contributor

Refactor all regridder classes to inherit from a single class.

@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #198 (0a6cd3c) into main (3440343) will decrease coverage by 0.50%.
The diff coverage is 97.46%.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   99.22%   98.73%   -0.50%     
==========================================
  Files          28       30       +2     
  Lines        3102     3323     +221     
==========================================
+ Hits         3078     3281     +203     
- Misses         24       42      +18
Impacted Files Coverage Δ
esmf_regrid/experimental/io.py 99.26% <83.33%> (-0.74%) ⬇️
esmf_regrid/experimental/unstructured_scheme.py 93.93% <89.47%> (-4.63%) ⬇️
esmf_regrid/schemes.py 96.09% <95.02%> (-1.36%) ⬇️
.../tests/unit/experimental/io/test_round_tripping.py 100.00% <100.00%> (ø)
...nstructured_scheme/test_GridToMeshESMFRegridder.py 100.00% <100.00%> (ø)
...nstructured_scheme/test_MeshToGridESMFRegridder.py 97.05% <100.00%> (-2.95%) ⬇️
..._scheme/test_regrid_rectilinear_to_unstructured.py 100.00% <100.00%> (ø)
..._scheme/test_regrid_unstructured_to_rectilinear.py 100.00% <100.00%> (ø)
...regrid/tests/unit/schemes/test_ESMFAreaWeighted.py 100.00% <100.00%> (ø)
...smf_regrid/tests/unit/schemes/test_ESMFBilinear.py 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenworsley stephenworsley mentioned this pull request Sep 14, 2022
Open
6 tasks
@stephenworsley stephenworsley mentioned this pull request Oct 10, 2022
Merged
4 tasks
@bjlittle bjlittle mentioned this pull request Oct 17, 2022
Open
@stephenworsley stephenworsley mentioned this pull request Mar 6, 2023
Merged
@trexfeathers trexfeathers mentioned this pull request Mar 10, 2023
Merged
8 tasks
@trexfeathers
Copy link
Contributor

More of this goodness please 🙏

#219 (comment)

trexfeathers
trexfeathers requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephenworsley, almost there now...

stephenworsley and others added 2 commits May 12, 2023 09:41
@stephenworsley @trexfeathers
Apply suggestions from code review
e9c12cc 
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
@stephenworsley
address review comments
0a6cd3c
@trexfeathers
Copy link
Contributor

Let's do it 🚀

@trexfeathers trexfeathers merged commit 68de5c5 into SciTools:main May 12, 2023
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request May 15, 2023
@stephenworsley
update changelog for SciTools#198
d187ee2
@stephenworsley stephenworsley mentioned this pull request May 15, 2023
Merged
trexfeathers added a commit that referenced this pull request May 15, 2023
@stephenworsley @trexfeathers
Update changelog for #198 (#267)
1690171 
* update changelog for #198

* Update CHANGELOG.md

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* address review comments

---------

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
@stephenworsley stephenworsley mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees

@trexfeathers trexfeathers

Labels
None yet
Projects
No open projects
🦥 Sprint: May 2023
Status: 🏁 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenworsley @trexfeathers