-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests on windows #557
Conversation
1679422
to
8febed7
Compare
From @SciTools/peloton Thanks for the PRs, we agree that improving our Windows support is a good idea. We'll review these when we're available (in a week or two). |
kindly ping for a review |
Sorry again for long delays, maxed out here on other stuff (Iris 3.12 release mostly). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 58.40% 58.40%
=======================================
Files 62 62
Lines 6433 6433
Branches 1150 1150
=======================================
Hits 3757 3757
Misses 2385 2385
Partials 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If the time is very limit I prefer we review the building PR first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see SciTools/.github#67
doesn't quiet understand this review comment, is there something need I to do ? |
In this case, nope. Its about propagating changes across our organisation. This change is specific to CF-Units so we can ignore it. |
can you dismiss ci's requested changes state from this PR? |
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trim21. Happy with this.
🚀 Pull Request
Description
setuptools can't find budunits2 in conda env on windows, so we need to prepare env for it.