Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on windows #557

Merged
merged 5 commits into from
Apr 3, 2025
Merged

ci: run tests on windows #557

merged 5 commits into from
Apr 3, 2025

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Feb 13, 2025

🚀 Pull Request

Description

setuptools can't find budunits2 in conda env on windows, so we need to prepare env for it.

@trim21 trim21 marked this pull request as ready for review February 13, 2025 05:00
@stephenworsley
Copy link
Contributor

From @SciTools/peloton Thanks for the PRs, we agree that improving our Windows support is a good idea. We'll review these when we're available (in a week or two).

@trim21
Copy link
Contributor Author

trim21 commented Mar 6, 2025

kindly ping for a review

@pp-mo
Copy link
Member

pp-mo commented Mar 12, 2025

kindly ping for a review

Sorry again for long delays, maxed out here on other stuff (Iris 3.12 release mostly).
Your time is coming soon !

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.40%. Comparing base (b0bf50c) to head (50b9822).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   58.40%   58.40%           
=======================================
  Files          62       62           
  Lines        6433     6433           
  Branches     1150     1150           
=======================================
  Hits         3757     3757           
  Misses       2385     2385           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trim21
Copy link
Contributor Author

trim21 commented Mar 12, 2025

If the time is very limit I prefer we review the building PR first.

@ESadek-MO ESadek-MO assigned HGWright and unassigned pp-mo Mar 19, 2025
scitools-ci[bot]
scitools-ci bot previously requested changes Mar 28, 2025
Copy link
Contributor

@scitools-ci scitools-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see SciTools/.github#67

@trim21
Copy link
Contributor Author

trim21 commented Mar 28, 2025

Please see SciTools/.github#67

doesn't quiet understand this review comment, is there something need I to do ?

@HGWright
Copy link
Contributor

Please see SciTools/.github#67

doesn't quiet understand this review comment, is there something need I to do ?

In this case, nope. Its about propagating changes across our organisation. This change is specific to CF-Units so we can ignore it.

@trim21
Copy link
Contributor Author

trim21 commented Mar 28, 2025

can you dismiss ci's requested changes state from this PR?

@trim21
Copy link
Contributor Author

trim21 commented Mar 28, 2025

Thanks

Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trim21. Happy with this.

@HGWright HGWright merged commit b66e711 into SciTools:main Apr 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants