Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtd remove unshallow #272

Merged
merged 2 commits into from
Jul 12, 2022
Merged

rtd remove unshallow #272

merged 2 commits into from
Jul 12, 2022

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jul 12, 2022

🚀 Pull Request

Description

This PR resolves this issue on RTD building for main:

image

Which didn't present itself whilst testing on a private branch for #271.

Here is the successful build of the documentation for this pull-request.

Closes #267

@bjlittle bjlittle requested a review from trexfeathers July 12, 2022 06:34
@bjlittle
Copy link
Member Author

bjlittle commented Jul 12, 2022

@trexfeathers I can't quite explain this... don't quite understand why this issue didn't happen for #271 when testing.

@trexfeathers
Copy link
Collaborator

@trexfeathers I can't quite explain this... don't quite understand why this issue didn't happen for #271 when testing.

@bjlittle I also want to understand why it's not a problem for Iris - see iris/.readthedocs.yml#L8-10

@trexfeathers
Copy link
Collaborator

This could plausibly be down to a difference in config within RTD. I set up cf-units as bare-bones as I could, so perhaps Iris has a better config that we should be mimicking.

@bjlittle
Copy link
Member Author

@trexfeathers I think it's a difference in the repos. iris has more history.

Also, it's clear that you do need to do git fetch --unshallow for iris otherwise the version is wrong.

Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjlittle and I now understand that git fetch --unshallow is invalid for cf-units, because cf-units (unlike Iris) is NOT a shallow repository. This might change in future if anything 'nasty' happens in the Git history, but the aim/hope is that it remains unshallow.

@trexfeathers trexfeathers merged commit 37c8400 into SciTools:main Jul 12, 2022
@bjlittle bjlittle deleted the remove-unshallow branch July 12, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTD is failing to build
2 participants