Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build wheels for macosx #269

Merged
merged 8 commits into from
Jul 11, 2022
Merged

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jul 9, 2022

🚀 Pull Request

Description

This PR extends the GHA CI wheel building to macosx.

Massive thanks to @alexgleith for super responsive testing of the macosx wheels on the fly 🥳

See #258

Closes #268

@bjlittle bjlittle force-pushed the ci-wheels-macos branch 2 times, most recently from ed447f2 to 8f2fe16 Compare July 9, 2022 22:01
@bjlittle bjlittle requested a review from trexfeathers July 11, 2022 09:05
Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever bit of flexibility 🙂
Couple of questions for you

Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjlittle

@trexfeathers trexfeathers merged commit 6b7c895 into SciTools:main Jul 11, 2022
@bjlittle
Copy link
Member Author

@trexfeathers Awesome, thanks for the swift review 💯 🚀

@bjlittle bjlittle deleted the ci-wheels-macos branch July 12, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for x86_64 macos wheels
2 participants