-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add udunits xml to wheel #191
Conversation
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 90.63% 90.96% +0.32%
==========================================
Files 7 6 -1
Lines 833 819 -14
Branches 105 103 -2
==========================================
- Hits 755 745 -10
+ Misses 64 62 -2
+ Partials 14 12 -2 Continue to review full report at Codecov.
|
@ocefpaf Okay, so I've put this in draft for the moment, as I've discovered a way to avoid the use of the I'll add my changes and test before taking this out of draft again 👍 |
@ocefpaf Okay, this is good to review now... fancy taking a peek? |
LGTM! |
You've got merge rights @ocefpaf, right? |
I believe I do but merging is blocked. I guess we need 1 approving review. |
@ocefpaf Awesome, nice one 🥇 |
🚀 Pull Request
Description
This PR supports #186, by injecting the associated UDUNITS2 xml files into a wheel build of
cf-units
.@ocefpaf To build in a
quay.io/pypa/manylinux2014_x86_64
docker container, I had to do the following:Note that, the UDUNITS2 XML files populate the
etc/share
directory only for abdist_wheel
and not asdist
.When a wheel installed
cf-units
distro executes it auto-generates an ephemeralsite.cfg
pointing to the bundled XML files, and the rest of the machinery works as normal. The wheel should be consistent with regards toudunits2
, as the wheel bundles theudunits2
dynamic library associated with theetc/share
XML files