Skip to content

Ensure collections.abc is used in python 3. Would fail with py38 without this change. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Ensure collections.abc is used in python 3. Would fail with py38 without this change. #142

merged 1 commit into from
Jan 30, 2019

Conversation

pelson
Copy link
Member

@pelson pelson commented Jan 30, 2019

No description provided.

@bjlittle bjlittle self-assigned this Jan 30, 2019
@bjlittle
Copy link
Member

bjlittle commented Jan 30, 2019 •
edited
Loading

@pelson No 🎲 🎲, thanks to the license headers... sigh

Fancy updating to the shiny new 2019 super improved year?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.434% when pulling 5d9b2b1 on pelson:abc_loc into d4cbe0b on SciTools:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.434% when pulling 5d9b2b1 on pelson:abc_loc into d4cbe0b on SciTools:master.

@bjlittle
Copy link
Member

@pelson Sweet, thanks 👍

@bjlittle bjlittle merged commit ea5cde8 into SciTools:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjlittle bjlittle

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pelson @bjlittle @coveralls