-
Notifications
You must be signed in to change notification settings - Fork 390
WHL: enable cp314 wheels #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WHL: enable cp314 wheels #2556
Conversation
a5dc144
to
ea6e917
Compare
Ah, of course |
Yeah, I figured that would be the case, so I didn't try too hard on the 3.14 aspect since we are still in rc's on many projects. Lets not wait another year to make a release though (note to self ;) ) so once our dependent projects release their wheels we should try to build and publish ours as well. |
I might forget about this PR when the time comes, so please don't hesitate to do what you please with it if it's any help in the future ! |
FYI (as I'm reviewing what packages I depend on have 3.14 and free-threading enabled) my PR to pyproj just got merged to |
Thanks ! I'll try to come back to this in a month or so and see where things are then ! |
Looks like pyproj 3.7.2 came early with cp314 wheels, so let's try this one more time |
7472598
to
2fd37fb
Compare
the current blocker is now shapely |
Dang you're quick. I just released pyproj a couple hours ago. |
(I get RSS alerts for many PyPI package, including pyproj :)) |
2fd37fb
to
f9a6d96
Compare
shapely 2.1.2 is out with cp314 wheels, let's try this again |
current blocker: fiona |
Oh wait that's only for the regular CI part, let me just drop that real quick then |
f9a6d96
to
9878d2e
Compare
wait, the wheel job didn't run. Can someone add the "Run cibuildwheel" label please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against freethreaded wheels, but I'm not sure if they work.
.github/workflows/release.yml
Outdated
CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-*" | ||
# Skip 32 bit builds and musllinux due to lack of numpy wheels | ||
CIBW_SKIP: "*-win32 *_i686 *-musllinux*" | ||
CIBW_SKIP: "*-win32 *_i686 *-musllinux* cp3*t-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually, this does nothing, because the freethreaded one is missing the trailing *
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. Fixed
9878d2e
to
1b8f288
Compare
Rationale
I missed the opportunity to do this in time for 0.25.0, but I just tried this on my fork and saw no compilation error, so I'm proposing this change now.
I notice the wheels are not immediately tested, so I'm adding 3.14 to CI too (but I haven't tried that part on my fork yet, so, opening as a draft)
Implications
Removing
CIBW_BUILD
has the effect of lettingcibuildwheel
take the wheel (pun intended) and select target versions for you, wherecibuildwheel
itself (currently 3.8) or the oldest version compatible withproject.requires-python
, as specified inpyproject.toml
, whichever is newer.cibuildwheel
, and usually include all ABI stable versions, so currently this goes up to 3.14I'm however also adding a filter to
CIBW_SKIP
, otherwisecp314t
wheels are also included by default, and I don't know what your plans are in this area.