-
Notifications
You must be signed in to change notification settings - Fork 390
ENH: Add HEALPix and rHEALPix projections #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For class names, do we want |
Also closes #2133 I think. |
Always enjoy seeing new projections be added! For the name, I would vote for HEALPix() and rHEALPix(). |
docs/make_projection.py
Outdated
instance_args = SPECIFIC_PROJECTION_KWARGS.get(prj, {}) | ||
|
||
prj_inst, instance_repr = create_instance(prj, instance_args) | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I added this here because I don't have PROJ 9.6 installed locally, so this didn't work when instantiated. Maybe there is a better way to approach this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I decided to upgrade my local PROJ and rebuild this file instead. I think it is valuable to keep the Spilhaus image in there. I'm not sure if there is still a better way to do this and allow building this file without all of the projections available...
I think I prefer the capitalization of "R" to indicate it is a class in Python by common convention, even if PROJ does lowercase it. Any other votes/preferences on naming? I think this is ready for review again, and I added in a review comment about the doc build process when someone doesn't have the latest PROJ installed. |
|
Rationale
This adds the HEALPix and rHEALPix projections from PROJ to Cartopy.
https://proj.org/en/9.4/operations/projections/healpix.html
https://proj.org/en/9.4/operations/projections/rhealpix.html
This replaces #1008 and allows for flexible globes/radii as well.
closes #882
closes #1008
closes #2133