This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
BLD: Updated tested numpy version to 1.9 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marqh, I said I would ping you when I put this one up. Cheers |
|
this is a sensible change, we are way past supporting numpy 1.7 |
|
Thanks @marqh |
DPeterK
reviewed
Nov 11, 2016
| @@ -5,7 +5,7 @@ python: | |||
| - "3.4" | |||
| - "3.5" | |||
| env: | |||
| - NUMPY="numpy==1.7" | |||
| - NUMPY="numpy==1.9" | |||
There was a problem hiding this comment.
Out of interest, what would happen if you unpinned NumPy entirely?
There was a problem hiding this comment.
numpy is unpinned in one part of the test matrix
we test against 1 pinned version and latest, so currently this is 1.9 and 1.11
|
Thanks @cpelley |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the minimum version of numpy that biggus is tested against with travis CI to 1.9
Matching the minimum requirements of iris.
This would facilitate making changes to biggus which would no longer require to be backward compatible with very old versions of numpy. In particular #176 would be made considerably simple by this change.