Skip to content

Templating: don't check the users who posted reviews #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trexfeathers wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Templating: don't check the users who posted reviews #256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ea25e9
Templating: don't check the users who posted reviews.
trexfeathers Feb 5, 2026
28d988e
Add a templating watermark.
trexfeathers Feb 5, 2026
1fe81da
Add noreply@github.com to the BOTS list.
trexfeathers Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions templates/_templating_scripting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@
"pre-commit-ci[bot]",
"app/pre-commit-ci",
"app/scitools-ci",
"web-flow",
]
TEMPLATING_HEADING = f"## [Templating]({SCITOOLS_URL}/.github/blob/main/templates)"
TEMPLATING_HEADING = (
"[TEMPLATING WATERMARK]: #\n\n"
f"## [Templating]({SCITOOLS_URL}/.github/blob/main/templates)"
)

_MAGIC_PREFIX = "@scitools-templating: please"
MAGIC_NO_PROMPT = re.compile(rf"{_MAGIC_PREFIX} no share prompt", re.IGNORECASE)
Expand Down Expand Up @@ -227,9 +231,6 @@ def prompt_share(args: argparse.Namespace) -> None:
# Can use a URL here for local debugging:
# pr_number = "https://github.com/SciTools/iris/pull/6901"

# current_user = gh_json("api user")["login"]
current_user = "scitools-ci" # Temporary testing patch.

body = gh_json(f"pr view {pr_number}", "body")["body"]
if MAGIC_NO_PROMPT.search(body):
print(
Expand Down Expand Up @@ -275,8 +276,7 @@ def post_review(review_body: str, review_type: ReviewType) -> None:
existing_reviews = json.loads(check_output(shlex.split(gh_command)))
reviews_to_edit = [
review for review in existing_reviews
if review["user"]["login"] == current_user
and review["body"].startswith(TEMPLATING_HEADING)
if review["body"].startswith(TEMPLATING_HEADING)
]
if reviews_to_edit:
# Edit the last existing review.
Expand Down
Loading