Accept CancellationToken in ChatSession.InitializeSessionFromHistoryAsync
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [NEW] support cancellation of `ChatSession.InitializeSessionFromHistoryAsync` - [NEW] improve usage of `CancellationToken`s in `LlamaExecutorBase` - [FIX] `CS1998` warnings
…nal parameters defined via interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ChatSession.InitializeSessionFromHistoryAsyncto accept an optionalCancellationTokenparameter (this method is is quite long-running in my application, so I need to be able to cancel it).To facilitate functionality of this token, various async methods defined in the
LlamaExecutorBasehave also been updated to accept an optionalCancellationToken, and implementations updated to pass the token down the call-stack.This PR additionally addresses minor compiler errors, such as
CS1998, relating to "async method not awaited".These changes could be considered a "breaking" API change, as any user implementations of
LlamaExecutorBasewould cease to compile.ChatSession.InitializeSessionFromHistoryAsyncCancellationTokens inLlamaExecutorBaseCS1998warnings