Skip to content

Update ContributingGuide.md #1657

Update ContributingGuide.md

Update ContributingGuide.md #1657

Triggered via pull request November 1, 2024 21:05
Status Success
Total duration 6m 43s
Artifacts 1

main.yml

on: pull_request
Matrix: Test
Fit to window
Zoom out
Zoom in

Annotations

34 warnings
Test (windows-release)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (windows-release): LLama/Common/InferenceParams.cs#L94
Nullability of reference types in return type of 'ISamplingPipeline? InferenceParams.SamplingPipeline.get' doesn't match implicitly implemented member 'ISamplingPipeline IInferenceParams.SamplingPipeline.get' (possibly because of nullability attributes).
Test (windows-release): LLama/ChatSession.cs#L782
Possible null reference argument for parameter 'executorState' in 'SessionState.SessionState(State? contextState, ExecutorBaseState executorState, ChatHistory history, List<ITextTransform> inputTransformPipeline, ITextStreamTransform outputTransform, IHistoryTransform historyTransform)'.
Test (windows-release): LLama/Common/PolymorphicJSONConverter.cs#L48
Dereference of a possibly null reference.
Test (windows-release): LLama/LLamaInstructExecutor.cs#L110
Possible null reference argument for parameter 'data' in 'Task InstructExecutor.LoadState(ExecutorBaseState data)'.
Test (windows-release): LLama/LLamaInstructExecutor.cs#L163
'IReadOnlyListExtensions.TokensEndsWithAnyString<TTokens>(TTokens, IList<string>?, SafeLlamaModelHandle, Encoding)' is obsolete: 'Use an Antiprompt processor instead'
Test (windows-release): LLama/LLamaInstructExecutor.cs#L159
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test (windows-release): LLama/LLamaExecutorBase.cs#L417
Non-nullable property 'Embeds' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (windows-release): LLama/LLamaExecutorBase.cs#L420
Non-nullable property 'EmbedInps' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (windows-release): LLama/LLamaExecutorBase.cs#L423
Non-nullable property 'SessionTokens' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (windows-release): LLama/LLamaExecutorBase.cs#L426
Non-nullable property 'LastTokens' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (linux-release)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (linux-release): LLama/Common/InferenceParams.cs#L94
Nullability of reference types in return type of 'ISamplingPipeline? InferenceParams.SamplingPipeline.get' doesn't match implicitly implemented member 'ISamplingPipeline IInferenceParams.SamplingPipeline.get' (possibly because of nullability attributes).
Test (linux-release): LLama/LLamaInteractExecutor.cs#L102
Possible null reference argument for parameter 'data' in 'Task InteractiveExecutor.LoadState(ExecutorBaseState data)'.
Test (linux-release): LLama/LLamaInteractExecutor.cs#L168
Dereference of a possibly null reference.
Test (linux-release): LLama/LLamaInstructExecutor.cs#L110
Possible null reference argument for parameter 'data' in 'Task InstructExecutor.LoadState(ExecutorBaseState data)'.
Test (linux-release): LLama/LLamaInteractExecutor.cs#L209
'IReadOnlyListExtensions.TokensEndsWithAnyString<TTokens>(TTokens, IList<string>?, SafeLlamaModelHandle, Encoding)' is obsolete: 'Use an Antiprompt processor instead'
Test (linux-release): LLama/LLamaInteractExecutor.cs#L205
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test (linux-release): LLama/LLamaInstructExecutor.cs#L163
'IReadOnlyListExtensions.TokensEndsWithAnyString<TTokens>(TTokens, IList<string>?, SafeLlamaModelHandle, Encoding)' is obsolete: 'Use an Antiprompt processor instead'
Test (linux-release): LLama/LLamaInstructExecutor.cs#L159
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test (linux-release): LLama/LLamaInteractExecutor.cs#L270
Dereference of a possibly null reference.
Test (linux-release): LLama/LLamaInteractExecutor.cs#L304
Possible null reference argument for parameter 'filename' in 'void StatefulExecutorBase.SaveSessionFile(string filename)'.
Test (osx-release)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (osx-release): LLama/Common/InferenceParams.cs#L94
Nullability of reference types in return type of 'ISamplingPipeline? InferenceParams.SamplingPipeline.get' doesn't match implicitly implemented member 'ISamplingPipeline IInferenceParams.SamplingPipeline.get' (possibly because of nullability attributes).
Test (osx-release): LLama/ChatSession.cs#L782
Possible null reference argument for parameter 'executorState' in 'SessionState.SessionState(State? contextState, ExecutorBaseState executorState, ChatHistory history, List<ITextTransform> inputTransformPipeline, ITextStreamTransform outputTransform, IHistoryTransform historyTransform)'.
Test (osx-release): LLama/LLamaInstructExecutor.cs#L110
Possible null reference argument for parameter 'data' in 'Task InstructExecutor.LoadState(ExecutorBaseState data)'.
Test (osx-release): LLama/LLamaInteractExecutor.cs#L102
Possible null reference argument for parameter 'data' in 'Task InteractiveExecutor.LoadState(ExecutorBaseState data)'.
Test (osx-release): LLama/LLamaInstructExecutor.cs#L163
'IReadOnlyListExtensions.TokensEndsWithAnyString<TTokens>(TTokens, IList<string>?, SafeLlamaModelHandle, Encoding)' is obsolete: 'Use an Antiprompt processor instead'
Test (osx-release): LLama/LLamaInstructExecutor.cs#L159
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Test (osx-release): LLama/LLamaInstructExecutor.cs#L269
Non-nullable property 'InputPrefixTokens' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (osx-release): LLama/LLamaInstructExecutor.cs#L274
Non-nullable property 'InputSuffixTokens' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test (osx-release): LLama/Common/PolymorphicJSONConverter.cs#L48
Dereference of a possibly null reference.
Test (osx-release): LLama/LLamaExecutorBase.cs#L417
Non-nullable property 'Embeds' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "logs". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
logs
4.84 MB