Features/refine model settings

[iceljc]

PR Type

Enhancement

---

Description

• Add IsDefault flags to model settings classes

• Refactor image and web search functions for dynamic model selection

• Improve file handling with new FileFullName property

• Update agent naming consistency across file handler functions

---

Diagram Walkthrough

flowchart LR
  A["Model Settings"] --> B["Add IsDefault flags"]
  B --> C["Dynamic Model Selection"]
  C --> D["Image Functions"]
  C --> E["Web Search Function"]
  F["File Information"] --> G["Add FileFullName property"]
  H["Agent Naming"] --> I["Consistent naming across functions"]

Loading

File Walkthrough

	Relevant files
Enhancement	9 files FileInformation.cs Add FileFullName computed property                                              +3/-0      LlmModelSetting.cs Add IsDefault flags to model settings                                        +15/-1    WebIntelligentSearchFn.cs Refactor for dynamic model selection and naming                    +17/-11  EditImageFn.cs Add dynamic model selection and improve file handling        +24/-7    GenerateImageFn.cs Implement dynamic model selection and agent consistency    +27/-6    ReadImageFn.cs Update agent naming for consistency                                            +2/-2      ImageCompletionProvider.Edit.cs Reorder variable initialization and fix state handling      +4/-3      ImageCompletionProvider.Generation.cs Reorder variable initialization for consistency                    +4/-3      ImageCompletionProvider.Variation.cs Reorder variable initialization pattern                                    +2/-1
Configuration changes	1 files FileInstructService.SelectFile.cs Update model name from gpt-4o-mini to gpt-4.1-mini              +1/-1
Bug fix	1 files ReadPdfFn.cs Fix agent loading method and naming                                            +3/-3
Documentation	1 files util-file-select_file_instruction.liquid Update instruction template formatting                                      +1/-1

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Null Handling FileFullName concatenates FileName and FileExtension without guarding null/empty values, which can yield leading/trailing dots or "null" segments; confirm upstream invariants or add safe formatting. public string FileFullName => $"{FileName}.{FileExtension}"; } Typo/User Feedback The returned success message contains typos and lost specific filename context; consider clearer user-facing text and include the edited file name if available. return $"Your image is successfylly editted."; } Model Default Change Default chat model changed from gpt-4o-mini to gpt-4.1-mini; verify availability and compatibility across environments to avoid runtime fallback issues. var model = options?.Model ?? "gpt-4.1-mini"; var provider = llmProviderService.GetProviders().FirstOrDefault(x => x == providerName); var completion = CompletionProvider.GetChatCompletion(_services, provider: provider, model: model);

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Don't hard-code OpenAI provider Several functions still hard-code provider="openai" and specific model names (e.g., WebIntelligentSearchFn, EditImageFn, GenerateImageFn, and file selection), which undermines the “dynamic model selection” goal and will fail in deployments not using OpenAI. Drive provider/model resolution from the current agent’s LlmConfig or the globally configured defaults via ILlmProviderService, selecting by capability (web search, image generation/edit) and honoring IsDefault flags with proper fallbacks. This makes the new IsDefault settings effective across providers and prevents runtime errors when OpenAI isn’t present. Examples: src/Infrastructure/BotSharp.Core/WebSearch/Functions/WebIntelligentSearchFn.cs [71] var provider = "openai"; src/Plugins/BotSharp.Plugin.FileHandler/Functions/EditImageFn.cs [102] var provider = "openai"; Solution Walkthrough: Before: // In WebIntelligentSearchFn.cs private (string, string) GetLlmProviderModel() { var provider = "openai"; // Hard-coded provider var model = "gpt-4o-mini-search-preview"; // Hard-coded default model var llmProviderService = _services.GetRequiredService<ILlmProviderService>(); var models = llmProviderService.GetProviderModels(provider); var foundModel = models.FirstOrDefault(x => x.WebSearch?.IsDefault == true) ?? models.FirstOrDefault(x => x.WebSearch != null); model = foundModel?.Name ?? model; return (provider, model); } After: // In WebIntelligentSearchFn.cs private (string, string) GetLlmProviderModel() { var llmProviderService = _services.GetRequiredService<ILlmProviderService>(); // Get provider from agent config or global settings, not hard-coded var agentConfig = GetCurrentAgentConfig(); // Hypothetical var provider = agentConfig.Provider ?? llmProviderService.GetDefaultProvider(); // Find the best model for the capability (WebSearch) from the resolved provider var models = llmProviderService.GetProviderModels(provider); var foundModel = models.FirstOrDefault(x => x.WebSearch?.IsDefault == true) ?? models.FirstOrDefault(x => x.WebSearch != null); // Fallback to a generic default model if no specific one is found var model = foundModel?.Name ?? agentConfig.Model ?? llmProviderService.GetDefaultModel(); return (provider, model); } Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a critical flaw where the provider is hard-coded as openai, which contradicts the PR's goal of dynamic model selection and limits portability.	High
General	Handle null FileExtension values The property doesn't handle null or empty FileExtension values, which could result in filenames ending with a dot (e.g., "document."). Add null/empty checking to avoid malformed filenames. src/Infrastructure/BotSharp.Abstraction/Files/Models/FileInformation.cs [47] -public string FileFullName => $"{FileName}.{FileExtension}"; +public string FileFullName => string.IsNullOrEmpty(FileExtension) ? FileName : $"{FileName}.{FileExtension}"; Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies that the new FileFullName property could produce malformed names if FileExtension is null or empty, and the proposed fix improves code robustness.	Low
More