refine http headers

[iceljc]

No description provided.

[GGHansome]

Auto Review Result:

Code Review Summary

Change Overview: The core objective of this change is to modify the IHttpRequestHook interface and related implementations to include an additional parameter Uri when adding HTTP headers. This change is aimed at providing more context when preparing request headers, potentially allowing headers to be configured based on the request URI.

Issues Identified

Issue 1: Function Signature Consistency

• Description: The method OnAddHttpHeaders in IHttpRequestHook was modified to include a Uri parameter. However, not all implementations or usages have been reviewed in this excerpt to ensure they handle the new parameter appropriately.
• Suggestion: Verify all instances where OnAddHttpHeaders is implemented and ensure they have been updated to match the new function signature. Ensure that they utilize the Uri efficiently.
• Example:

  // Before
  void OnAddHttpHeaders(HttpHeaders headers);
  // After
  void OnAddHttpHeaders(HttpHeaders headers, Uri uri);

Issue 2: HTTP Method Logic Change

• Description: In the GetHttpMethod function, logic was changed such that if the method is "GET", it defaults to HttpMethod.Get, whereas previously a default of HttpMethod.Post was set. This is potentially a significant change in behavior.
• Suggestion: Clearly document this change. Review all places where this method is called to ensure that the logic change does not disrupt existing functionality.
• Example:

  // Before
  default:
      matchMethod = HttpMethod.Post;
  // After
  default:
      matchMethod = HttpMethod.Get;

Overall Evaluation

The code changes increase the flexibility and context-awareness of HTTP headers preparation by incorporating the request URI. However, the changes in HTTP method selection and signature updates for the hooks require thorough examination for consistency and backward compatibility. Documentation and tests should be updated to reflect these changes safely.