Skip to content

Add profile page and enhance existing UX #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add profile page and enhance existing UX #15

merged 1 commit into from
Jan 23, 2024

Conversation

@visagang
Copy link
Contributor

  1. Add my profile page and update navigation
  2. Add loader to sign up page

Oceania2018
Oceania2018 reviewed Jan 23, 2024
View reviewed changes
src/routes/page/myProfile/+page.svelte
import Loader from '$lib/common/Loader.svelte';

/**
* @type {{ full_name: any; id?: string; user_name?: string | undefined; first_name?: string | undefined; last_name?: string | undefined; email?: string | undefined; role?: string | undefined; avatar?: string | undefined; color?: string | undefined; token?: string | undefined; }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is not looking good. Can we define like this?
/** @type {Object} CurrentUserModel
@Property {string} [user_name] */

@Oceania2018 Oceania2018 merged commit 2d24627 into SciSharp:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oceania2018 Oceania2018 Oceania2018 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@visagang @Oceania2018