Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RuboCop static code analyzer #12

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added RuboCop static code analyzer #12

wants to merge 8 commits into from

Conversation

iamrajiv
Copy link

@iamrajiv iamrajiv commented Jan 12, 2021

Fixes: #4

@Uditgulati
Copy link
Member

Fix the RuboCop test and get the whole thing to work locally (also post some evidence that it works fine like screenshots or some output that RuboCop gives) then put a comment that it's done, I'll have a look then.

Ignore the ruby-head test, it's failing in the repo too.

@iamrajiv
Copy link
Author

@Uditgulati I think RuboCop linter is failing because GitHub token is not set for Ruby-Sparse repository.

@Shekharrajak
Copy link
Member

Why few checks failed ? Can you please have a look

@iamrajiv
Copy link
Author

iamrajiv commented Feb 10, 2021

@Shekharrajak Ruby-Sparse test / test (ubuntu, head) test is failing in the repo too and I think RuboCop linter / lint is failing because the GitHub token is not set for Ruby-Sparse repository.

@Shekharrajak
Copy link
Member

@Shekharrajak Ruby-Sparse test / test (ubuntu, head) test is failing in the repo too and I think RuboCop linter / lint is failing because GitHub token is not set for Ruby-Sparse repository.

Do we have open issue for this ? If not, then please open one so that we can track it and someone pick this task.

@iamrajiv
Copy link
Author

iamrajiv commented Feb 15, 2021

@Shekharrajak I have opened an issue #13 on Ruby-Sparse test / test (ubuntu, head) test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Rubocop and C linter
3 participants