Description
We have a function called clapack_laswp
, which permutes columns, but as far as I can tell, there is no equivalent function called clapack_?laswp
in ATLAS, or anywhere else in the world (if you google clapack_laswp, you just end up with results for nmatrix). John, do you remember where this code came from? There is a standard laswp
function in LAPACK, but it exchanges rows instead of columns. So at the least, I think we should rename this to prevent confusion.
Furthermore, it seems like when calling clapack_laswp
the last element of the pivot vector is ignored, although I am not really sure how this is supposed to work.
Also, we have #laswp!
method for NMatrix, which behaves differently from the clapack_laswp
and friends, due to #346. I think the default "intuitive" behavior is good for a method #permute_columns
, but not for a method name #laswp
, since all the other functions called *laswp behave differently. So I guess I think that #permute_columns
and #laswp
should be different methods with different behavior and not aliased to each other.