Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to daru-io #423

Open
zverok opened this issue Oct 8, 2017 · 1 comment
Open

Transition to daru-io #423

zverok opened this issue Oct 8, 2017 · 1 comment

Comments

@zverok
Copy link
Collaborator

zverok commented Oct 8, 2017

Should be done in daru-1.0 branch:

  1. daru-io becomes hard dependency for daru
  2. All Daru#from_something and Daru#to_something functionality should be removed from daru gem, alongside with corresponding dependencies and tests.
  3. Documentation on import/export should explain clearly where to look for importing and exporting data.
  4. Make sure no functionality (even minor/outdated) will be lost, at least without good reason for it. Interface changes, on the contrary, accepted and welcome.

@athityakumar, it is for you :)

@zverok zverok added this to the Version 1.0 milestone Oct 8, 2017
@athityakumar
Copy link
Member

  1. Documented as a to-do in issue Add runtime dependency on daru-io #434
  2. Taken care of, by PR Removes IO modules from Daru #430 (yet to be merged)
  3. Would it be enough to include something like this in daru's YARD docs?
  4. I think there has been no lose (Except the Marshal methods, as suggested in PR Removes IO modules from Daru #430). Any suggestion for interface changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants