Added Charteditor #96

Prakriti-nith · 2018-06-10T15:11:39Z

This PR is opened over the commits of Chartwrapper and is in progress (code, tests, documentation and examples all are incomplete). User needs to set class_chart as Charteditor.
Actually, I am facing a problem in this. Charteditor is working fine in rails app but in IRuby notebook, the dialog box is appearing behind the notebook as in the examples here.
I can see it working (that is above the content of jupyter notebook) if I explicitly set the z-index of the dialog box (ChartEditor) in developer tools. But that is of no help as I can not change the code of the dialog box. Is there any way I can make this work?

Also, I wanted to know why are we generating the googlecharts' code with script and without script in display.rb. We have already defined script tags in the template so we'll definitely be generating the script without the script tags?

Prakriti-nith · 2018-06-17T02:54:23Z

As it is a continuation of ChartWrapper, I will rebase it after ChartWrapper gets merged.

coveralls · 2018-07-14T23:12:46Z

Pull Request Test Coverage Report for Build 662

533 of 538 (99.07%) changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 98.014%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/daru/view/adapters/googlecharts.rb	6	7	85.71%
lib/daru/view/adapters/googlecharts/display.rb	98	100	98.0%
spec/adapters/googlecharts/generate_javascript_spec.rb	237	239	99.16%

Totals
Change from base Build 648:	0.1%
Covered Lines:	3110
Relevant Lines:	3173

💛 - Coveralls

coveralls · 2018-07-14T23:12:46Z

Pull Request Test Coverage Report for Build 610

312 of 313 (99.68%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 97.292%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/daru/view/adapters/googlecharts.rb	5	6	83.33%

Totals
Change from base Build 608:	0.3%
Covered Lines:	2731
Relevant Lines:	2807

💛 - Coveralls

Prakriti-nith · 2018-07-18T19:54:52Z

@Shekharrajak can you please review this PR?

Prakriti-nith · 2018-07-22T08:35:16Z

ChartEditor is working fine in rails app but in IRuby notebook, the dialog box is appearing behind the notebook as in the example here.
Below are the screenshots of rails example (can see in this PR in demo_daru-view).

Shekharrajak · 2018-07-22T08:07:36Z

lib/daru/view/adapters/googlecharts/data_table_iruby.rb

@@ -62,7 +62,9 @@ def google_table_version
    end

    def package_name
-      'table'
+      return 'table' unless


ChartEditor is going through data_table_iruby.rb :O . But why ?

ChartEditor works for both google charts and tables, and code to generate the table is written in data_table_iruby.rb. charteditor package is loaded in Google Datatables when chart_class is set to Charteditor.

Is there any example or documentation written, which describes this usecase ?

I have written the rails examples in demo_daru-view and also in the method documentation here.

Write examples in web apps and iruby as well, if haven't.

Shekharrajak · 2018-07-22T08:08:52Z

lib/daru/view/adapters/googlecharts/data_table_iruby.rb

-      js << "\n  \t\toptions: #{js_parameters(@options)},"
-      js << "\n  \t\tcontainerId: '#{element_id}',"
-      js << "\n  \t\tview: #{extract_option_view}"
+      js << "\n  \twrapper_#{element_id.tr('-', '_')} = "\


Same code 2 times ??

Shekharrajak · 2018-07-22T08:14:17Z

lib/daru/view/adapters/googlecharts/display.rb

-    def draw_wrapper
-      return "\n  \twrapper.draw();" if
+    def draw_wrapper(element_id)
+      return "\n  \twrapper_#{element_id.tr('-', '_')}.draw();" if


Just want to know, what if we don't provide element_id ?

If we use only the wrapper (without id) then the chart editor will work only on the last chart. That is, edit button (of any chart) will show the dialog box for the last chart only.

Shekharrajak · 2018-07-22T08:15:40Z

lib/daru/view/adapters/googlecharts/display.rb

      user_options[:chart_class].to_s.capitalize == 'Chartwrapper'
-      ''
+      js = ''
+      js << "\n  \twrapper_#{element_id.tr('-', '_')}.draw();"


same line at 172 .

Shekharrajak · 2018-07-22T08:20:17Z

spec/adapters/googlecharts/base_chart_spec.rb

@@ -35,6 +35,12 @@
      chart_class: 'ChartWrapper'
    )
  }
+  let (:plot_spreadsheet_charteditor) {
+    Daru::View::Plot.new(
+      data_spreadsheet, {width: 800, view: {columns: [0, 1]}}, chart_class: 'Charteditor'


line length

Prakriti-nith · 2018-07-28T11:56:52Z

@Shekharrajak can you please review this PR also?

Shekharrajak · 2018-07-29T10:46:54Z

Please resolve conflicts and run all the examples again.

Prakriti-nith · 2018-07-29T20:17:53Z

@Shekharrajak I have created a new module DisplayJavascript as the module length of Display increased to > 200 and rubocop was throwing the error. I have also rechecked all the examples of GoogleCharts and committed.

Prakriti-nith · 2018-08-01T14:38:05Z

@Shekharrajak I have separated the modules in different files. As the same thing needs to be done with the Export GoogleCharts PR, I will update that one after this gets merged.

Shekharrajak · 2018-08-02T18:24:14Z

lib/daru/view/adapters/googlecharts/generate_javascript.rb

@@ -0,0 +1,148 @@
+module GenerateJavascript


It should be inside GoogleVisualr module, isn't it ?

module GenerateJavascript is already included in BaseChart and DataTables class which is in GoogleVisualr, so, I think it is not required.

Shekharrajak · 2018-08-02T18:25:52Z

lib/daru/view/adapters/googlecharts/data_table_iruby.rb

@@ -62,7 +62,9 @@ def google_table_version
    end

    def package_name
-      'table'
+      return 'table' unless


Write examples in web apps and iruby as well, if haven't.

Prakriti-nith added 5 commits June 5, 2018 22:15

Added Chartwrapper

abacb2d

Added documentation

3dd8fff

Load packages explicitly in chartwrapper

7680fd2

Added Charteditor

6a70844

Added example

d531fe2

Prakriti-nith changed the title ~~Charteditor wrapper~~ Added Charteditor Jun 10, 2018

Prakriti-nith added 2 commits June 12, 2018 18:25

Update tests and documentation

a30450f

Line length

5defa69

Prakriti-nith added 3 commits June 22, 2018 20:45

Use already present template

3d1e97a

Changed wrapper_id to wrapper

be2939d

Resolve conflicts

81ac864

Move common methods to display

85cc0b9

Shekharrajak reviewed Jul 22, 2018

View reviewed changes

Prakriti-nith added 3 commits July 23, 2018 00:14

Remove redundancy

f99a319

Merge branch 'master' into charteditor_wrapper

68d3125

Fix rubocop offences

eccd285

Merge branch 'master' into charteditor_wrapper

cf66066

Prakriti-nith force-pushed the charteditor_wrapper branch from 976405b to 83749c4 Compare July 29, 2018 20:09

Added module DisplayJavaScript, rechecked examples

3829d87

Prakriti-nith force-pushed the charteditor_wrapper branch from 83749c4 to 3829d87 Compare July 29, 2018 20:14

Prakriti-nith added 2 commits August 1, 2018 19:47

Refactored display.rb into separate files

6f94d7b

Remove extra variables from specs

5de4ed7

Shekharrajak approved these changes Aug 2, 2018

View reviewed changes

Shekharrajak merged commit 6c5b0e7 into SciRuby:master Aug 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Charteditor #96

Added Charteditor #96

Prakriti-nith commented Jun 10, 2018 •

edited

Loading

Prakriti-nith commented Jun 17, 2018

coveralls commented Jul 14, 2018 •

edited

Loading

coveralls commented Jul 14, 2018

Prakriti-nith commented Jul 18, 2018

Prakriti-nith commented Jul 22, 2018

Shekharrajak Jul 22, 2018

Prakriti-nith Jul 22, 2018

Shekharrajak Jul 29, 2018

Prakriti-nith Jul 29, 2018

Shekharrajak Aug 2, 2018

Shekharrajak Jul 22, 2018

Shekharrajak Jul 22, 2018

Prakriti-nith Jul 22, 2018

Shekharrajak Jul 22, 2018

Shekharrajak Jul 22, 2018

Prakriti-nith commented Jul 28, 2018

Shekharrajak commented Jul 29, 2018

Prakriti-nith commented Jul 29, 2018 •

edited

Loading

Prakriti-nith commented Aug 1, 2018

Shekharrajak Aug 2, 2018

Prakriti-nith Aug 4, 2018

Shekharrajak Aug 2, 2018

Added Charteditor #96

Added Charteditor #96

Conversation

Prakriti-nith commented Jun 10, 2018 • edited Loading

Prakriti-nith commented Jun 17, 2018

coveralls commented Jul 14, 2018 • edited Loading

Pull Request Test Coverage Report for Build 662

💛 - Coveralls

coveralls commented Jul 14, 2018

Pull Request Test Coverage Report for Build 610

💛 - Coveralls

Prakriti-nith commented Jul 18, 2018

Prakriti-nith commented Jul 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Prakriti-nith commented Jul 28, 2018

Shekharrajak commented Jul 29, 2018

Prakriti-nith commented Jul 29, 2018 • edited Loading

Prakriti-nith commented Aug 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Prakriti-nith commented Jun 10, 2018 •

edited

Loading

coveralls commented Jul 14, 2018 •

edited

Loading

Prakriti-nith commented Jul 29, 2018 •

edited

Loading