Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Daru::DataTables::DataTable to Daru::View::DataTable #114

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

Prakriti-nith
Copy link
Contributor

Updated specs and renamed Daru::DataTables::DataTable to Daru::View::DataTable.
This PR runs in parallel with #22 in daru-data_tables, so some of the test cases will not work right now.

@coveralls
Copy link

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 671

  • 4 of 11 (36.36%) changed or added relevant lines in 3 files are covered.
  • 89 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.7%) to 98.552%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daru/view/adapters/datatables.rb 1 3 33.33%
spec/table_spec.rb 0 2 0.0%
spec/adapters/datatables_spec.rb 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
lib/daru/view.rb 1 98.55%
lib/daru/view/table.rb 1 93.75%
lib/daru/view/adapters/googlecharts/display.rb 2 96.55%
spec/table_spec.rb 4 100.0%
lib/daru/view/adapters/nyaplot/iruby_notebook.rb 4 40.0%
lib/daru/view/adapters/googlecharts.rb 10 91.53%
lib/daru/view/adapters/datatables.rb 11 93.33%
spec/adapters/datatables_spec.rb 56 100.0%
Totals Coverage Status
Change from base Build 660: 0.7%
Covered Lines: 3131
Relevant Lines: 3177

💛 - Coveralls

@Shekharrajak
Copy link
Member

Please finish it as soon as possible.

@Prakriti-nith
Copy link
Contributor Author

@Shekharrajak I have tried the examples again, I think the PR is fine.

@@ -1,6 +1,7 @@
require 'rspec'
require 'simplecov'
require 'daru/view'
require 'daru/data_tables'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is required to run the specs.

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the folder structure of the daru-data_tables . So another PR has to be created for it.

Merging it for now as temporary solution.

@Shekharrajak Shekharrajak merged commit caa71dd into SciRuby:master Aug 23, 2018
@Shekharrajak
Copy link
Member

Refer Shekharrajak/daru-data_tables#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants