-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Daru::DataTables::DataTable to Daru::View::DataTable #114
Conversation
Pull Request Test Coverage Report for Build 671
💛 - Coveralls |
Please finish it as soon as possible. |
@Shekharrajak I have tried the examples again, I think the PR is fine. |
@@ -1,6 +1,7 @@ | |||
require 'rspec' | |||
require 'simplecov' | |||
require 'daru/view' | |||
require 'daru/data_tables' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is required to run the specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the folder structure of the daru-data_tables
. So another PR has to be created for it.
Merging it for now as temporary solution.
Updated specs and renamed
Daru::DataTables::DataTable
toDaru::View::DataTable
.This PR runs in parallel with #22 in daru-data_tables, so some of the test cases will not work right now.