Rename and set as a breaking change #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of breaking changes in this one, especially the sign change and the mixed adjoint (continuous + discrete) causing changes to the direct version. But the docs are also all fixed so yay! The reason for the name change is because this package is the core package for all of SciML's integration with AD and sensitivity analysis. For example, the issue with Integrals.jl is that it cannot handle all of the vjps... which are defined here. Optimization.jl needs adjoints, defined here for vjps. Etc. so the name change reflects that, and since we also had a massive breaking API change, it makes sense to pair this together as essentially a new package.
|
Downstream tests should fail with this change? |
This was referenced Jun 25, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of breaking changes in this one, especially the sign change and the mixed adjoint (continuous + discrete) causing changes to the direct version. But the docs are also all fixed so yay!
The reason for the name change is because this package is the core package for all of SciML's integration with AD and sensitivity analysis. For example, the issue with Integrals.jl is that it cannot handle all of the vjps... which are defined here. Optimization.jl needs adjoints, defined here for vjps. Etc. so the name change reflects that, and since we also had a massive breaking API change, it makes sense to pair this together as essentially a new package.