Refresh ModelingToolkit benchmark under v7 stack#1582
Open
ChrisRackauckas-Claude wants to merge 1 commit into
Open
Refresh ModelingToolkit benchmark under v7 stack#1582ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
ChrisRackauckas-Claude
force-pushed
the
clean/ModelingToolkit
branch
from
0780440 to
f008949
Compare
Pkg.update on benchmarks/ModelingToolkit refreshes the Manifest under the OrdinaryDiffEq v7 / SciMLBase v3 / ModelingToolkit 11 stack. Notable bumps: - SymbolicUtils 4.26.0 -> 4.30.1 (clears the precompile method-overwrite bug that PR SciML#1571 also hit on the AutomaticDifferentiation refresh). - ModelingToolkit 11.24.1 -> 11.26.4, ModelingToolkitBase 1.33.1 -> 1.36.3, Symbolics 7.21.0 -> 7.24.2. - SciMLBase 3.7.1 -> 3.13.0, LinearSolve 3.75.0 -> 3.80.0, SciMLLogging 1.9.1 -> 2.0.0. - OrdinaryDiffEq subpackages (Core, Default, BDF, Rosenbrock, SDIRK, Tsit5, Verner, Differentiation) bumped to current point releases on the v2/v3/v4 lines. No .jmd source changes needed: static scan found no surviving v7-era patterns (no bool autodiff/verbose, no top-level precs, no sol[i] timestep indexing, no old prob_func signature). Local Pkg.instantiate clean; Pkg.update produced the expected Manifest diff and precompile of the refreshed graph succeeded (the residual XSteam method-overwrite warning is the upstream XSteam bug that the ThermalFluid.jmd already works around by pinning the fixed rev at script-runtime). The folder's prior CI red (job 75199969458, run 25374549824) was a runner-workspace corruption on amdci1-1 ("Can't find action.yml under _actions/actions/checkout/v6", "No such file or directory" for bash working directory), not a real benchmark failure. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
clean/ModelingToolkit
branch
from
f008949 to
898263d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified locally under the v7 stack (OrdinaryDiffEq v7 / SciMLBase v3 / ModelingToolkit 11). The folder's prior CI red on job 75199969458 (run 25374549824, amdci1-1) was a runner-workspace corruption — annotations included "Can't find action.yml under .../_actions/actions/checkout/v6" and "No such file or directory" for the bash working directory — not real benchmark breakage.
What I did
Pkg.instantiateonbenchmarks/ModelingToolkitclean (with the expected SymbolicUtils 4.26.0 precompile-overwrite warnings that PR Refresh AutomaticDifferentiation under v7 stack #1571 already documented for AutomaticDifferentiation)..jmdfiles (Multibody_Robot.jmd,RCCircuit.jmd,ThermalFluid.jmd) for surviving v7-era patterns (boolautodiff/verbose, top-levelprecs,sol[i]for timesteps, oldprob_func(prob, i, repeat)ensemble signature) — none found. Solver calls already useRodas5(autodiff = AutoFiniteDiff())/FBDF(autodiff = AutoForwardDiff()).Pkg.updateto refresh the Manifest; precompile of the new graph succeeded (residual XSteam method-overwrite is the upstream XSteam bug the ThermalFluid script already works around by pinningrev = "f2a1c..."viaPkg.addat script runtime).Notable Manifest bumps
Single folder, Manifest-only change. Please ignore until reviewed by @ChrisRackauckas.