Bump autodiff tests #1275
Open
Bump autodiff tests #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalle
reviewed
Jun 13, 2025
| @@ -27,7 +27,7 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f" | |||
| BenchmarkTools = "1" | |||
| DataFrames = "1" | |||
| DataFramesMeta = "0.15" | |||
| DifferentiationInterface = "0.9" | |||
| DifferentiationInterface = "0.6" | |||
There was a problem hiding this comment.
Suggested change
| DifferentiationInterface = "0.6" | |
| DifferentiationInterface = "0.7" |
unless something is blocking it?
|
The failure is really weird here |
ChrisRackauckas
force-pushed
the
autodiff
branch
from
187ddca to
2251879
Compare
ChrisRackauckas
force-pushed
the
autodiff
branch
from
2251879 to
ff66bb4
Compare
ChrisRackauckas
pushed a commit
that referenced
this pull request
Aug 1, 2025
This commit addresses performance regression issues identified in PR #1275 by: 1. **Remove broken MooncakeVJP integration**: - Remove Mooncake dependency from Project.toml - Remove MooncakeVJP usage from BrussScaling.jmd - Fix import statements and VJP method configurations 2. **Fix dependency version issues**: - Keep DifferentiationInterface at v0.6 (compatible version) - Remove references to non-functional MooncakeVJP method 3. **Add regression tests**: - Add test_bruss_regression.jl to prevent future regressions - Tests verify ForwardDiff numerical stability - Tests check that problematic methods are properly removed The root cause was incomplete MooncakeVJP integration causing numerical instabilities in ForwardDiff operations, not actual performance regression. ForwardDiff failures with NaN dt errors made it appear slower when it was actually failing due to dependency incompatibilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.