feat: support symbolic indexing of a subset of the system #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AayushSabharwal
force-pushed
the
as/symbolic-save-idxs
branch
from
3dd562a
to
e6d6b28
Compare
AayushSabharwal
force-pushed
the
as/symbolic-save-idxs
branch
3 times, most recently
from
d47c3bf
to
2e778e0
Compare
src/solutions/ode_solutions.jl
Outdated
| T14, | ||
| T15, | ||
| T16} where { | ||
| T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16 <: SavedSubsystem} |
There was a problem hiding this comment.
this seems a bit fragile. Why not a trait function?
There was a problem hiding this comment.
Yeah I guess that is a better option
|
This should roll out to all solution types? |
|
Yes. I'll add the rest. |
AayushSabharwal
force-pushed
the
as/symbolic-save-idxs
branch
2 times, most recently
from
34f8553
to
620b0b2
Compare
AayushSabharwal
force-pushed
the
as/symbolic-save-idxs
branch
from
620b0b2
to
c219343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft while I add more tests
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.