Fix function call line split following Catalyst.jl PR #1306 #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unnecessarily split function call in DomainError hint registration. Line length reduced to 123 characters, improving readability. Following Catalyst.jl PR #1306 guidelines. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| occursin( | ||
| "will only return a complex result if called with a complex argument. Try ", | ||
| e.msg) | ||
| if e isa DomainError && occursin("will only return a complex result if called with a complex argument. Try ", e.msg) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if e isa DomainError && occursin("will only return a complex result if called with a complex argument. Try ", e.msg) | |
| if e isa DomainError && | |
| occursin("will only return a complex result if called with a complex argument. Try ", e.msg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix unnecessary line split in Julia code following the guidelines established in Catalyst.jl PR #1306. This PR improves code readability by consolidating a short expression that was unnecessarily split across multiple lines.
Background
These formatting issues are being addressed upstream in JuliaFormatter.jl PR #934, which implements algorithmic fixes to prevent these unnecessary line splits. However, since that PR is not yet merged, manual fixes are needed in the meantime to improve code readability.
Changes Made
Fixed 1 instance of problematic line split:
Example Fix
Before:
After:
Rationale
Following Catalyst.jl PR #1306's approach:
Note
This is part of a systematic effort to apply the same formatting improvements across 10+ SciML repositories.
🤖 Generated with Claude Code