Skip to content

Fix IntegralProblem deprecation error in tests #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025

Conversation

ChrisRackauckas
Copy link
Member

Summary

  • Fixed deprecation error in test/function_building_error_messages.jl that was causing tests to fail with --depwarn=error
  • Removed domain patterns (0.0, 1.0) and ([0.0], [1.0]) that expand to the deprecated IntegralProblem{iip}(f, lb, ub, p) constructor
  • Kept correctly wrapped patterns ((0.0, 1.0),) and (([0.0], [1.0]),) that use the new IntegralProblem{iip}(f, (lb, ub), p) constructor

Test plan

  • Verified tests pass with julia --depwarn=error
  • Confirmed no regression in normal test execution
  • All existing test cases still covered with proper constructor patterns

This fix ensures that SciMLBase tests can run cleanly with deprecation warnings treated as errors, which is important for catching deprecation issues in CI.

🤖 Generated with Claude Code

claude added 2 commits July 30, 2025 10:59
Fix compatibility constraint preventing upgrade to PrecompileTools v1.3.x
by allowing both v1.2.1 and v1.3 in Project.toml.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Removed domain patterns that expand to deprecated constructor signature.
The patterns (0.0, 1.0) and ([0.0], [1.0]) were causing the test to use
the deprecated IntegralProblem{iip}(f, lb, ub, p) constructor instead of
the new IntegralProblem{iip}(f, (lb, ub), p) constructor.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas merged commit d3e51b8 into master Jul 31, 2025
52 of 62 checks passed
@ChrisRackauckas ChrisRackauckas deleted the fix-integral-problem-deprecation branch July 31, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants