feat: implement remake(::LinearProblem)
#1053
Conversation
src/SciMLBase.jl
Outdated
| @public SymbolicLinearInterface, get_new_A_b, create_parameter_timeseries_collection, | ||
| get_saveable_values, save_discretes! |
There was a problem hiding this comment.
it's not really public though?
There was a problem hiding this comment.
What isn't? SymbolicLinearInterface is what MTK populates
There was a problem hiding this comment.
Where's the docs? And do we really want other people building on this?
There was a problem hiding this comment.
Where's the docs?
It has docstrings. Would you like me to add it to a doc page somewhere? Maybe the LinearProblem docstring?
And do we really want other people building on this?
Technically a bunch of this kind of stuff (e.g. the remake hooks, really anything that dispatches on prob.f.sys) that "anybody can build upon" but realistically MTK is the only one doing it besides contrived implementations in tests.
There was a problem hiding this comment.
Even if only MTK builds upon it, it is still public API of SciMLBase. Renaming a field will break MTK, which means either this is public API or MTK technically depends on internals.
There was a problem hiding this comment.
There is a big difference between API designated for one package to build on and public API
There was a problem hiding this comment.
If we can do that, I'm up for it. Will update this and the docstring for the struct accordingly.
There was a problem hiding this comment.
It's not ready to be public until we've settled on the interface there. And it should be part of SII probably if it is? Just remove from public for now and let's get it right before telling people they should build on it.
There was a problem hiding this comment.
The changes are already on this branch. It is no longer public.
AayushSabharwal
force-pushed
the
as/fix-linprob-remake
branch
from
8bd571c to
841f23a
Compare
src/SciMLBase.jl
Outdated
| @public get_new_A_b, create_parameter_timeseries_collection, | ||
| get_saveable_values, save_discretes! |
There was a problem hiding this comment.
These are though? And I don't know their interface, it's not defined in SciMLBase docs, nor do I think these necessarily should be?
There was a problem hiding this comment.
Okay. I'll remove them too. Given the current state of tests, can I remove this and merge?
AayushSabharwal
force-pushed
the
as/fix-linprob-remake
branch
from
841f23a to
9b4d3ec
Compare
@jClugstor this should fix your remake issue.