Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events to reactionsystem by wrapping them in a constraintsystem #82

Merged
merged 4 commits into from
Jul 1, 2022

Conversation

paulflang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #82 (c1c470e) into main (ff5c09b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           1        1           
  Lines         231      231           
=======================================
  Hits          228      228           
  Misses          3        3           
Impacted Files Coverage Δ
src/reactionsystem.jl 98.70% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulflang paulflang marked this pull request as ready for review June 30, 2022 18:10
@paulflang paulflang requested a review from isaacsas June 30, 2022 18:10
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You could add an example that actually uses an event and checks the ODE solution does what it should if you want to be a bit more thorough about the event actually running correctly.

@paulflang paulflang merged commit e697e39 into main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants