Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl/fix assignment rule #77

Merged
merged 6 commits into from
Jun 21, 2022
Merged

Pl/fix assignment rule #77

merged 6 commits into from
Jun 21, 2022

Conversation

paulflang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #77 (f462b73) into main (bc5f0fa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   98.66%   98.67%   +0.01%     
==========================================
  Files           1        1              
  Lines         224      226       +2     
==========================================
+ Hits          221      223       +2     
  Misses          3        3              
Impacted Files Coverage Δ
src/reactionsystem.jl 98.67% <100.00%> (+0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulflang paulflang marked this pull request as ready for review June 21, 2022 00:33
@anandijain
Copy link
Contributor

add the patch bump in the pr

lgtm

@anandijain
Copy link
Contributor

what does this change though?

@paulflang
Copy link
Member Author

Sam told me that rules are only valid if 0 is on the lhs. Having a non-zero lhs is fine if you run structual_simplify. But if structural_simplify fails and you want to create an ODEProblem from the non-sutructural_simplify'd system, you need this fix.

@paulflang paulflang merged commit 5ef2abf into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants