-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pl/constant specs as ps #72
Conversation
@isaacsas : SciML/Catalyst.jl#522 works for me locally. I just don't know how to best get it to work here on CI, cause when I push the Manifest I get an error that it was created with a different Julia version (using 1.7 locally) and if I don't push it I would assume that it does not find your Catalyst branch. Do I need to fix this? If so how? |
Sounds good. I’ll try to fix up the API stuff and then make a new breaking release. Should be tomorrow evening at the latest if that works. |
Great, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 98.61% 98.66% +0.04%
==========================================
Files 1 1
Lines 217 224 +7
==========================================
+ Hits 214 221 +7
Misses 3 3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@anandijain , this PR treats constant species as parameters. It assigns them the new |
…MLToolkit.jl into pl/constant-specs-as-ps
lgtm |
…ents per event trigger
Trying Catalyst#constant-specs-as-ps.
cc @isaacsas