Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl/constant specs as ps #72

Merged
merged 21 commits into from
Jun 20, 2022
Merged

Pl/constant specs as ps #72

merged 21 commits into from
Jun 20, 2022

Conversation

paulflang
Copy link
Member

Trying Catalyst#constant-specs-as-ps.
cc @isaacsas

@paulflang
Copy link
Member Author

@isaacsas : SciML/Catalyst.jl#522 works for me locally. I just don't know how to best get it to work here on CI, cause when I push the Manifest I get an error that it was created with a different Julia version (using 1.7 locally) and if I don't push it I would assume that it does not find your Catalyst branch. Do I need to fix this? If so how?
Otherwise Catalyst#constant-specs-as-ps seems good to merge from my perspective.

@isaacsas
Copy link
Member

Sounds good. I’ll try to fix up the API stuff and then make a new breaking release. Should be tomorrow evening at the latest if that works.

@paulflang
Copy link
Member Author

Great, thanks!

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #72 (a9eae61) into main (0b4dcb8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   98.61%   98.66%   +0.04%     
==========================================
  Files           1        1              
  Lines         217      224       +7     
==========================================
+ Hits          214      221       +7     
  Misses          3        3              
Impacted Files Coverage Δ
src/reactionsystem.jl 98.66% <100.00%> (+0.04%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulflang paulflang marked this pull request as ready for review June 18, 2022 19:02
@paulflang
Copy link
Member Author

@anandijain , this PR treats constant species as parameters. It assigns them the new isconstantspecies=true metadata in Catalyst v12 (IIUC this allows them to participate as reactants/products and enable correct interpretation of mass action kinetics). Could you please review?

@anandijain
Copy link
Contributor

lgtm

@paulflang paulflang merged commit bc5f0fa into main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants