Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl fix argument error #16

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Pl fix argument error #16

merged 2 commits into from
Jul 19, 2021

Conversation

paulflang
Copy link
Member

@paulflang paulflang commented Jul 19, 2021

this is to fix #14

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #16 (e5da3c8) into main (21bd09c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files           1        1           
  Lines         157      157           
=======================================
  Hits          134      134           
  Misses         23       23           
Impacted Files Coverage Δ
src/reactionsystem.jl 85.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bd09c...e5da3c8. Read the comment docs.

@paulflang
Copy link
Member Author

@ChrisRackauckas : I cannot seem to add @exaexa as a reviewer here.

@anandijain
Copy link
Contributor

nobody merge this

@paulflang paulflang merged commit 0c738cd into main Jul 19, 2021
@giordano
Copy link

I cannot seem to add @exaexa as a reviewer here.

The dropdown menu on the right only shows members of the organisation or collaborators to the repo.

@paulflang paulflang deleted the pl-fixArgumentError branch July 19, 2021 19:21
@anandijain
Copy link
Contributor

dude i literally just said dont merge this

@paulflang
Copy link
Member Author

oh man, i thought you meant "why does nobody merge this" rather than "don't merge this" and still wondering why you hadn't approved yet.

@anandijain
Copy link
Contributor

from now on just dont merge anything yourself please

@paulflang
Copy link
Member Author

well, i think i can merge myself if i have a positive review, which i thought i had. but that was a misinterpretation of your statement. so, please try to avoid phrases that could be misinterpreted by non native speakers.
anyway, what is your reason that this should not be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutorial does not work
3 participants