Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl/catalystupdate #113

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Pl/catalystupdate #113

merged 2 commits into from
Mar 5, 2023

Conversation

paulflang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #113 (e73bd76) into main (d5d8073) will decrease coverage by 5.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   94.23%   88.47%   -5.77%     
==========================================
  Files           6        6              
  Lines         295      295              
==========================================
- Hits          278      261      -17     
- Misses         17       34      +17     
Impacted Files Coverage Δ
src/reactions.jl 94.39% <100.00%> (-4.67%) ⬇️
src/systems.jl 83.11% <100.00%> (-9.20%) ⬇️
src/utils.jl 88.88% <100.00%> (-5.56%) ⬇️
src/events.jl 88.46% <0.00%> (-7.70%) ⬇️
src/rules.jl 92.68% <0.00%> (-2.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulflang
Copy link
Member Author

@SebastianM-C : here the pr works, but the push does not. does that mean that main will work after merging. cause let's to that then.

@paulflang
Copy link
Member Author

No, wait. somehow this PR also triggered the CI in #112 . Probably because they are indeed the same. Anyway. is this good to merge?

@paulflang paulflang merged commit e73bd76 into main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants