Merged
Conversation
- Extend `SciMLBase` compat to `"2.77.0, 3.1"`. - Bump version to 0.2.4. - Add `SciMLBase.derivative_discontinuity!` overloads for `OperatorSplittingIntegrator` and `SplitSubIntegrator` alongside the existing `DiffEqBase.u_modified!` overloads, guarded by `@static if isdefined(SciMLBase, :derivative_discontinuity!)`. - Update the `SciMLBase.u_modified!(child, true)` call in `forward_sync_internal!` to dispatch to `derivative_discontinuity!` on v3+ via the same `isdefined` guard, so it hits the direct method instead of the deprecated forward. SciMLBase v3 renamed `u_modified!` → `derivative_discontinuity!` with an `@deprecate` shim on the old name. Existing overloads still dispatch for legacy callers, but callers using the new name would otherwise hit the generic `error(...)` fallback. The `isdefined` guards keep the code compiling on both SciMLBase v2 and v3. Note: local tests cannot be run — `Pkg.resolve()` fails for any env containing SciMLBase 3.1 because OrdinaryDiffEq in the registry still pins `RecursiveArrayTools ≤ 3.54`. CI will reproduce the same resolution error until upstream bumps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Courtesy PR for the SciMLBase v3 release.
SciMLBasecompat to"2.77.0, 3.1".SciMLBase.derivative_discontinuity!overloads forOperatorSplittingIntegratorandSplitSubIntegratorinsrc/integrator.jlalongside the existingDiffEqBase.u_modified!methods, guarded by@static if isdefined(SciMLBase, :derivative_discontinuity!).SciMLBase.u_modified!(child, true)call inforward_sync_internal!(src/utils.jl:77) to dispatch toderivative_discontinuity!on v3+ via the sameisdefinedguard, so the call hits the direct method instead of the deprecated forward.SciMLBase v3 renamed
u_modified!→derivative_discontinuity!with an@deprecateshim on the old name. Existing overloads still dispatch for legacy callers, but callers that have migrated to the new name would otherwise hit the genericerror(...)fallback. Theisdefinedguards keep the code compiling on both v2 and v3.Known limitation
Local tests cannot be run:
Pkg.resolve()fails on any env containing SciMLBase 3.1 becauseOrdinaryDiffEqin the registry still pinsRecursiveArrayTools ≤ 3.54. Expect CI to fail at thePkg.addstep until upstream bumps.Reference pattern
Same
@static if isdefined(SciMLBase, :derivative_discontinuity!)shim used in SciML/DiffEqCallbacks.jl#300.cc @ChrisRackauckas
🤖 Generated with Claude Code