Fix umbrella QA project count after multirate split - #4204
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Fix umbrella QA project count after multirate split#4204ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed and why
Update the umbrella QA guard from 39 to 40 projects.
OrdinaryDiffEqMultirateImplicit, added by #4115, depends onOrdinaryDiffEqCoreand declares aMuladdMacrocompat floor, so it is intentionally included by this check.A scripted bisect identified 4bf7627 as the first failing commit. Its parent produces 39 matching projects; that commit adds
OrdinaryDiffEqMultirateImplicitas the 40th. I found no existing issue or open PR for this failure.Verification
Failing before the fix on clean
upstream/master:The same failure occurred in the introducing PR's Actions job: https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/31338186806/job/93308671126.
Passing after the fix:
Formatting and spelling:
All three exited successfully with no output.
Not verified
I did not run
GROUP=Everything, GPU tests, or downstream groups. This changes only the expected size of the project set already exercised by the QA group. No docs or public API were changed, so the docs build was not run.