Skip to content

Add isconnector to Model type + add all metadata to Model.structure #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 5, 2023
Merged

Add isconnector to Model type + add all metadata to Model.structure #2204

merged 4 commits into from
Jul 5, 2023

Conversation

@ven-k
Copy link
Member

@ven-k ven-k commented Jul 4, 2023

  • While here, changes, the typeof Model.structure[:components] as Vector{Symbols} to match the rest.
  • Adds the test to default value of an extended component (here Capacitor)

YingboMa
YingboMa reviewed Jul 5, 2023
View reviewed changes
YingboMa
YingboMa reviewed Jul 5, 2023
View reviewed changes
@ven-k ven-k force-pushed the vkb/isconnector branch from 013f363 to a661f56 Compare July 5, 2023 15:30
@YingboMa
Copy link
Member

YingboMa commented Jul 5, 2023

Format

@ven-k ven-k force-pushed the vkb/isconnector branch from a661f56 to f963fea Compare July 5, 2023 15:39
@ven-k ven-k changed the title Add isconnector to Model type Add isconnector to Model type + add all metadata to Model.structure Jul 5, 2023
@YingboMa YingboMa merged commit 47d8f05 into SciML:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ven-k @YingboMa