Skip to content

Conversation

@ChrisRackauckas
Copy link
Member

Fixes #807 (comment)

@jClugstor please take care with these kinds of issues in the future.

Fixes #807 (comment)

@jClugstor please take care with these kinds of issues in the future.
recomputed as needed.
"""
mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S}
mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S, V <: LinearVerbosity}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S, V <: LinearVerbosity}
mutable struct LinearCache{
TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S, V <: LinearVerbosity}

@RomeoV
Copy link
Contributor

RomeoV commented Oct 30, 2025

This is missing the fix in

cache = LinearCache{typeof(A), typeof(b), typeof(u0_), typeof(p), typeof(alg), Tc,
typeof(Pl), typeof(Pr), typeof(reltol), typeof(assumptions.issq),
typeof(sensealg)}(
A, b, u0_, p, alg, cacheval, isfresh, precsisfresh, Pl, Pr, abstol, reltol,
maxiters, verbose_spec, assumptions, sensealg)

(see my PR, which either superseedes this one or can be closed when this has landed).

@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch October 30, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LinearVerbosity introduces JET regression

3 participants