Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CuQR is not present in CUDA.jl for julia 1.8+ #123

Closed
avik-pal opened this issue Apr 13, 2022 · 4 comments
Closed

CuQR is not present in CUDA.jl for julia 1.8+ #123

avik-pal opened this issue Apr 13, 2022 · 4 comments

Comments

@avik-pal
Copy link
Member

https://github.com/JuliaGPU/CUDA.jl/blob/f52201036272591b74b994dd7d9df1496ba1f88a/lib/cusolver/linalg.jl#L72 removes CuQR
@rayegun rayegun mentioned this issue Apr 14, 2022
Closed
@vpuri3 vpuri3 mentioned this issue Apr 19, 2022
Closed
@ChrisRackauckas
Copy link
Member

Wait, why @maleadt ? What are we supposed to use here instead in v1.8?

@maleadt
Copy link

maleadt commented May 17, 2022 •
edited
Loading

LinearAlgebra.QR. See JuliaLang/julia#42594 for JuliaGPU/CUDA.jl#1449 replacing JuliaGPU/CUDA.jl#1194 to fix JuliaGPU/CUDA.jl#1193. This whole change was because you requested support for more factorizations, so I'm surprised about you being surprised 😛

@ChrisRackauckas
Copy link
Member

Oh I see. Yes, then https://github.com/SciML/LinearSolve.jl/pull/130/files#diff-4c8f9e26491b28a6897e9cf2c7f8d59c2f4c9b5fc66e1067a4d4fd8e3fd98226 solves this issue because enough has been upstreamed that we don't need to carry around those overloads. I forgot everything got upstreamed 😅

@ChrisRackauckas
Copy link
Member

Solved in #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cuqr vpuri3/LinearSolve.jl
3 participants
@maleadt @ChrisRackauckas @avik-pal