This repository was archived by the owner on Jul 19, 2023. It is now read-only.
This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Better testing #384
Open
Description
Currently most tests are of the form
@test a ≈ b atol=0.01
which uses the L2-norm and so can give errors even if the vectors are equal within tol elementwise (L-inf norm). (Linf(x) <= L2(x) <= sqrt(n)Linf(x))
Should we be testing instead
@test all(isapprox.(a, b, rtol = 0.01))
? Or do we really want to test the L2 norm?
See https://discourse.julialang.org/t/unit-test-equality-for-arrays/8138/13
Metadata
Metadata
Assignees
Labels
No labels