fix deprecated call

[thevolatilebit]

Since JuliaLang/julia#39448, getproperty has been deprecated in favor of getfield.

[ChrisRackauckas]

That PR is only about Pairs, I don't see how it applies here?

[thevolatilebit]

I get

┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr
│   caller = DualEltypeChecker at forwarddiff.jl:62 [inlined]
└ @ Core ~/.julia/packages/DiffEqBase/iK5G7/src/forwarddiff.jl:62

Maybe T in

struct DualEltypeChecker{T}
    x::T
    counter::Int
    DualEltypeChecker(x::T, counter::Int) where {T} = new{T}(x, counter + 1)
end
function (dec::DualEltypeChecker)(::Val{Y}) where {Y}
    isdefined(dec.x, Y) || return Any
    anyeltypedual(getproperty(dec.x, Y), dec.counter)
end

is of type Pairs?

The proposed change seems to fix this.

[ChrisRackauckas]

The solution would then be to create a separate dispatch on function (dec::DualEltypeChecker{<:Pairs})(::Val{Y}) where {Y} which uses getfield (and put a comment about that PR above it. Most of the time, you want to use getproperty: getfield is usually the incorrect thing to do. But it sounds like on Pairs you do want to use getfield.

[thevolatilebit]

Thanks, updated the PR.

[ChrisRackauckas]

Can you add a test with @test_nowarn?

[ChrisRackauckas]

Test failure looks real

[thevolatilebit]

Thanks, sure, the issue is that Pairs seems to be available only in v1.7+. Will update that.

[ChrisRackauckas]

Beautiful. Don't worry about the formatter, I'll merge and run it. Thanks!

[thevolatilebit]

Beautiful. Don't worry about the formatter, I'll merge and run it. Thanks!

Great, many thanks!