Skip to content

Add nfail to FPSolver #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add nfail to FPSolver #220

merged 2 commits into from
Nov 22, 2021

Conversation

ChrisRackauckas
Copy link
Member

Required for OrdinaryDiffEq 5.68 due to SciML/OrdinaryDiffEq.jl#1488

Required for OrdinaryDiffEq 5.68 due to SciML/OrdinaryDiffEq.jl#1488
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review November 22, 2021 20:32
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we don't have to lower bound OrdinaryDiffEq since in previous version nfails will just be ignored?

@ChrisRackauckas ChrisRackauckas merged commit b66acc2 into master Nov 22, 2021
@ChrisRackauckas
Copy link
Member Author

Yup it would just be ignored so we're good.

@ChrisRackauckas ChrisRackauckas deleted the fpsolvernfail branch November 22, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants