Skip to content

[wip] Fix LinearAlgebra.lmul! on GPU #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[wip] Fix LinearAlgebra.lmul! on GPU #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e71eaae
specify method for vcat to avoid ambiguity
vpuri3 Oct 30, 2023
88ed614
Revert "specify method for vcat to avoid ambiguity"
vpuri3 Oct 31, 2023
cd4b136
test on jl v1.10
vpuri3 Oct 31, 2023
8f5e9e6
version num
vpuri3 Oct 31, 2023
3f4e29f
resolve https://github.com/jonniedie/ComponentArrays.jl/actions/runs/…
vpuri3 Oct 31, 2023
6da99a0
Merge branch 'testv1.10' into vcat
vpuri3 Oct 31, 2023
1f55461
parameterized CA Types
vpuri3 Nov 1, 2023
9f3b768
restricted vcat operations to T<:Number to resolve method ambiguities…
vpuri3 Nov 1, 2023
98c70c6
bump version
vpuri3 Nov 1, 2023
16506f4
Update .github/workflows/ci.yml
vpuri3 Nov 1, 2023
332be8c
remove additional type parameterization from CArray, CVector, CMatrix…
vpuri3 Nov 1, 2023
3f0e026
Revert "Update .github/workflows/ci.yml"
vpuri3 Nov 1, 2023
315910b
lmul
vpuri3 Nov 1, 2023
8b2ca50
Merge branch 'main' into lmul
vpuri3 Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/linear_algebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,6 @@ function LinearAlgebra.axpby!(α::Number, x::ComponentArray, β::Number, y::Comp
axpby!(α, getdata(x), β, getdata(y))
return ComponentArray(y, getaxes(y))
end

lmul!(a::Number, B::ComponentArray) = ComponentArray(lmul!(a, getdata(B)), getaxes(B))

14 changes: 13 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ caa = ComponentArray(a = ca, b = sq_mat)

_a, _b, _c = Val.((:a, :b, :c))


## Tests
@testset "Allocations and Inference" begin
@test @ballocated($ca.c.a.a) == 0
Expand Down Expand Up @@ -690,6 +689,19 @@ end
@test_throws ArgumentError axpby!(2, x, 3, y)
end

@testset "lmul!" begin
a = rand()
x = ComponentArray(a = rand(4), b = rand(4))

xdata = copy(getdata(x))
xaxes = getaxes(x)

y = lmul!(a, x)
@test y == x
@test getdata(x) ≈ a * xdata
@test getaxes(x) == xaxes
end

@testset "Autodiff" begin
include("autodiff_tests.jl")
end
Expand Down