-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix remaining doc issues #943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the warning settings back to the SciML defaults now then?
@@ -1,7 +1,7 @@ | |||
# [Introduction to Catalyst](@id introduction_to_catalyst) | |||
In this tutorial we provide an introduction to using Catalyst to specify | |||
chemical reaction networks, and then to solve ODE, jump, and SDE models | |||
generated from them. At the end we show what mathematical rate laws and | |||
generated from them[1]. At the end we show what mathematical rate laws and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is supposed to be a reference then I'd just convert the list back to a footnote. I only switched it because it was giving errors when it was unreferenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, was a bit unsure if that's what you were doing. I will check how the printed docs looks like, but converting back to a list makes sense.
Good point, agreed. |
I switched unreferenced footnote sections to lists, but if they are referenced it makes sense to keep them as footnotes. |
Feel free to merge after you are done with the updates. |
Fixes remaining things that causes errors/warnings in the docs