-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14 ready] RDME and graph SSAs #737
Conversation
This one shoudl also have better formatting and comments as compared to the previous PR. |
I thought spatially varying mass action jump rates are already supported? That is what a |
Ahh, didn't know that that was supported already. |
ba3dac7
to
0227018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Coveralls report that all the new lines added are not covered. I don't understand why that is. Is the test accidentally calling some other functions instead of the newly added ones?
- We should add a correctness test.
test/spatial_reaction_systems/lattice_reaction_systems_jumps.jl
Outdated
Show resolved
Hide resolved
I have renamed the "Correctness Tests" header. Good point of the coverage, the file wasn't being run but added now, thanks! |
2fc7ccf
to
f094dc7
Compare
Won’t that run CI on the branch for all PRs and merges forever now? |
It will until we remove it, which we will do with the v14 release. And all PRs until then will be for the v14 branch anyway. This is what we want right, and it is not like there is another way? |
2bec547
to
9f63d30
Compare
9f63d30
to
c14dc10
Compare
276f54e
to
23ee006
Compare
23ee006
to
1bb2b08
Compare
1bb2b08
to
09bd10a
Compare
To avoid rebasing hell this is simply a new version of #663. You might have some input on simpler ways to compute the (non-spatial) mass action Jumps @isaacsas, but otherwise, this is good to go. Currently vertex parameters must be uniform across the grid (and this is enforced). Once @Vilin97 have his PRs merged over at JumpProcesses, this requirement can be lightened.
I have added support for spatial jumps. Creating and solving a problem is relatively easy:
Current limitations: