Skip to content

997 Resolve size_t underflow while removing dublicates in dynamic NPIs by using int #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024
Merged

997 Resolve size_t underflow while removing dublicates in dynamic NPIs by using int #998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/memilio/epidemiology/dynamic_npis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ void implement_dynamic_npis(DampingExprGroup& damping_expr_group, const std::vec
for (auto& damping_expr : damping_expr_group) {
//go from the back so indices aren't invalidated when dampings are removed
//use indices to loop instead of reverse iterators because removing invalidates the current iterator
for (auto i = size_t(0); i < damping_expr.get_dampings().size() - 1; ++i) {
for (auto i = int(0); i < int(damping_expr.get_dampings().size()) - 1; ++i) {
auto it = damping_expr.get_dampings().rbegin() + i;

//look for previous damping of the same type/level
Expand Down