Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Apr 4, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • simulation of 2021 paper

If need be, add additional information and what the reviewer should look out for in particular:

  • Some dampings are not used in cpp and thus are commented out in python aswell

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@MaxBetzDLR MaxBetzDLR linked an issue Apr 4, 2024 that may be closed by this pull request
2 tasks
@MaxBetzDLR
Copy link
Member Author

Simulation creates following gif:
simulation

@MaxBetzDLR MaxBetzDLR requested a review from HenrZu April 4, 2024 13:39
@codecov
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (f59d955) to head (f90a8bf).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10056    10072   +16     
=======================================
+ Hits         9688     9704   +16     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great extension :) Looks very good. A few small comments. Also, we should save & compare the graphs in cpp and py before merging again.

MaxBetzDLR and others added 3 commits April 12, 2024 13:57
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
HenrZu
HenrZu previously approved these changes Apr 22, 2024
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good work! :)

@HenrZu HenrZu dismissed their stale review April 22, 2024 19:24

new suggestion

…many.py

Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@HenrZu HenrZu merged commit d1c751b into main Apr 24, 2024
@HenrZu HenrZu deleted the 990-run-2021-simulation-in-python branch April 24, 2024 07:36
reneSchm pushed a commit that referenced this pull request May 24, 2024
- 2021 Simulation with the secirvvs is now also available in python

Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run 2021 simulation in python

3 participants