Skip to content

Conversation

@khoanguyen-dev
Copy link
Member

@khoanguyen-dev khoanguyen-dev commented Mar 20, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Set a default for the age group parameters (false).
  • Fix unit tests and benchmarks by explicitly setting the parameters.
  • Extend CustomIndexArray to allow for a convenient syntax to set multiple entries to the same value, e.g. parameters.get()[{Agegroup(1), Agegroup(2)}] = true;

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #869

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (a245aee) to head (6777fda).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   96.34%   96.32%   -0.03%     
==========================================
  Files         129      129              
  Lines       10072    10071       -1     
==========================================
- Hits         9704     9701       -3     
- Misses        368      370       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khoanguyen-dev khoanguyen-dev requested a review from dabele April 22, 2024 13:14
@dabele dabele merged commit 3f602b1 into main Apr 29, 2024
@dabele dabele deleted the 869-default-values-of-agegroupgotoschoolwork-abm-parameters branch April 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default values of AgeGroupGotoSchool/Work ABM parameters

3 participants