Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Mar 20, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Functionality to simulate the IDE model with a seasonality has been added.
  • The test for the function check_constraints() of the Parameters class was rewritten. The use of the class Model made the test unnecessarily complicated.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #793.

@lenaploetzke lenaploetzke added class::feature A feature to be implemented for some part of the software status::in progress This issue is in progess. loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. labels Mar 20, 2024
@lenaploetzke lenaploetzke self-assigned this Mar 20, 2024
@lenaploetzke lenaploetzke linked an issue Mar 20, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (ce75c58) to head (ce2e748).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   96.36%   96.34%   -0.03%     
==========================================
  Files         123      129       +6     
  Lines        9844    10056     +212     
==========================================
+ Hits         9486     9688     +202     
- Misses        358      368      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Mar 20, 2024
@lenaploetzke lenaploetzke requested a review from reneSchm March 20, 2024 12:35
lenaploetzke and others added 2 commits March 22, 2024 09:42
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from reneSchm March 22, 2024 14:25
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! There are only two comments that could be updated, then we're done here.

Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from reneSchm April 2, 2024 07:43
@reneSchm reneSchm merged commit a5cbb91 into main Apr 2, 2024
@reneSchm reneSchm deleted the 793-add-seasonality-to-ide-model branch April 2, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Seasonality to IDE model

3 participants