-
Notifications
You must be signed in to change notification settings - Fork 19
55 Write mobility data #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 96.44% 96.63% +0.18%
==========================================
Files 135 137 +2
Lines 11286 11196 -90
==========================================
- Hits 10885 10819 -66
+ Misses 401 377 -24 ☔ View full report in Codecov by Sentry. |
|
Using the setup in our simulation with ~30.000 edges and 50 simulation days, the size of the Edges.h file is 135mb. |
|
There is an inconsistency in our project between the use of the terms migrated and mobility. I would leave them here for now and edit this PR after merging so that we only use mobility. |
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not looked at everything yet, and we should first discuss whether the condensed edge result (see my other comment), but here are some more things I found.
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still some documentation that is missing new arguments, briefs or the param flags (i.e. [in], [out], [inout]). Please also make sure to use full sentences.
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think functionality wise this branch is fine, only the documentation needs a little touch up.
Could you please also add a short comment at the start of each new test that explains what it does, and, optimally, states the test case?
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #55