Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Mar 18, 2024

Changes and Information

The CI currently fails due to a bug in Asan that got triggered by an update to the GitHub runner Ubuntu image. This PR adds a (presumably temporary) workaround, described here.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm marked this pull request as ready for review March 18, 2024 14:37
@reneSchm reneSchm requested a review from dabele March 18, 2024 14:38
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (aca4b34) to head (76e9bf4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   96.23%   96.21%   -0.02%     
==========================================
  Files         122      122              
  Lines        9684     9638      -46     
==========================================
- Hits         9319     9273      -46     
  Misses        365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabele dabele merged commit f005eaf into main Mar 18, 2024
@dabele dabele deleted the try-fix-sanitizer branch March 18, 2024 17:13
reneSchm added a commit that referenced this pull request Mar 21, 2024
dabele pushed a commit that referenced this pull request Mar 21, 2024
workaround has been deployed globally by github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants